- Quote variables
- Remove unnecessary subshells
- Use local variables
- Unify _chef_*s_remote functions
- Prefix auxillary functions with _knife_*
- Use _call_program when invoking the knife command to silence stderr
output
Having a vim modeline or emacs local variable line somewhere in the
middle of the file isn't really helpful. By default, vim will only
check the first and last 5 lines of a file for a modeline (assuming the
modeline option is enabled). Emacs is even more strict about the type
of local variable line that was in use, it will only check the first
line of the file or the second line if the first line specifies a script
interpreter (which isn't the case here).
Move the vim modeline to the end of the file so that it can actually be
found by vim but is out of the way for editing. For emacs more work is
required, convert that to the more verbose Local Variables syntax which
emacs will look for starting 3000 characters from the end of the file.
Also there is no zsh mode for emacs (according to
zsh-users/zsh-completions#75), use the "Shell-Script" mode instead.
This seems to automatically detect that the files are for zsh.
I'm not an emacs user, so I haven't tested that portion much. But, this
does at least improve the syntax highlighting there.
Shohei YOSHIDA
midchildan
Luxing Huang
nicoulaj
Mark McKinstry
Gabriel Rosendorf
Mark Cornick
Mark Cornick
Aaron Schrab