From 9fa28becbaad71ef25675f64eb6c19b2351faf86 Mon Sep 17 00:00:00 2001 From: "V.Sannikov" Date: Tue, 21 Feb 2023 17:56:33 +0300 Subject: [PATCH 1/2] Fixed `vboxmanage closemedium` redundant parameters completion: the command takes not more than two positional parameters. --- src/_virtualbox | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/_virtualbox b/src/_virtualbox index da08903..1d37a35 100644 --- a/src/_virtualbox +++ b/src/_virtualbox @@ -172,7 +172,7 @@ _vboxmanage() { _arguments \ '--delete[Deletes the image file]' \ '1:type:(disk dvd floppy)' \ - '*:file:_files' \ + '2:file:_files' \ && ret=0 ;; (storageattach) From 234e5d3e6126b334c1af220ea3b14c4586c2c659 Mon Sep 17 00:00:00 2001 From: "V.Sannikov" Date: Tue, 21 Feb 2023 18:14:13 +0300 Subject: [PATCH 2/2] Fix `vboxmanage` medium-related commands parameters: These commands accept a file name (or an UUID), not a VM name, as a positional parameter. --- src/_virtualbox | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/_virtualbox b/src/_virtualbox index 1d37a35..abe1118 100644 --- a/src/_virtualbox +++ b/src/_virtualbox @@ -224,7 +224,7 @@ _vboxmanage() { (showmediuminfo) _arguments \ '1:medium:(disk dvd floppy)' \ - '2:machine:_vboxmachines' \ + '2: :_files' \ && ret=0 ;; (createmedium) @@ -252,7 +252,7 @@ _vboxmanage() { '--setlocation=[Specifies the new location of the medium]: :_files' \ '--type=[Specifies the new mode type of an existing image]: :(normal immutable writethrough multi-attach shareable readonly)' \ '1:medium:(disk dvd floppy)' \ - '2:machine:_vboxmachines' \ + '2: :_files' \ && ret=0 ;; (clonemedium) @@ -261,8 +261,8 @@ _vboxmanage() { '--format=[Specifies the file format of the target medium]: :(VDI VMDK VHD RAW)' \ '--variant=[Specifies the file format variant for the target medium]:variant' \ '1:medium:(disk dvd floppy)' \ - '2:machine:_vboxmachines' \ - '3:machine:_vboxmachines' \ + '2: :_files' \ + '3: :_files' \ && ret=0 ;; (encryptmedium) @@ -271,7 +271,7 @@ _vboxmanage() { '--oldpassword=[Specifies the original encryption password]:password' \ '--cipher=[Specifies the cipher to use for encryption]: :(AES-XTS128-PLAIN64 AES-XTS256-PLAIN64)' \ '--newpasswordid=[Specifies a new password identifier]:password' \ - '1:machine:_vboxmachines' \ + '1: :_files' \ && ret=0 ;; (convertfromraw)