From c059bbdfe6abeb2aa3c51dff69989201ea465727 Mon Sep 17 00:00:00 2001 From: David Ross Date: Sat, 25 Aug 2018 14:56:06 -0700 Subject: [PATCH 1/2] Fix kak_sessions not sending _values enough arguments Using zsh 5.4.2, I am occasionally running into an error "_values:compvalues:11: not enough arguments". When it doesn't occur, instead, one of the kakoune sessions does not appear as part of autocompletion. This fixes both problems for me by providing a description as described in http://zsh.sourceforge.net/Doc/Release/Completion-System.html#Completion-System. "The first non-option argument is used as a string to print as a description before listing the values. " --- src/_kak | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/_kak b/src/_kak index 9fd2540..868c873 100644 --- a/src/_kak +++ b/src/_kak @@ -43,7 +43,7 @@ _kak_sessions() { session_ids=($(_call_program session_ids kak -l)) - _values "${session_ids[@]}" + _values 'kak sessions' "${session_ids[@]}" } _kak() { From 9a215c194cdeafc3d1d2fc11e5b89151f5aebd9a Mon Sep 17 00:00:00 2001 From: David Ross Date: Sat, 25 Aug 2018 17:37:09 -0700 Subject: [PATCH 2/2] Replace _values with compadd, and other cleanup recommended Thanks @okapia! --- src/_kak | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/_kak b/src/_kak index 868c873..6079f36 100644 --- a/src/_kak +++ b/src/_kak @@ -42,8 +42,10 @@ # ------------------------------------------------------------------------------ _kak_sessions() { - session_ids=($(_call_program session_ids kak -l)) - _values 'kak sessions' "${session_ids[@]}" + local -a session_ids expl + session_ids=($(_call_program session_names kak -l)) + _description session-ids expl "session name" + compadd "$expl[@]" -a session_ids } _kak() {