From f37143161905ca23bc5e2737dafae50b6c90e4ad Mon Sep 17 00:00:00 2001
From: Martin Tournoij <martin@arp242.net>
Date: Wed, 3 Jun 2020 11:38:52 +0800
Subject: [PATCH 1/2] pgsql: add -X to psql commands to prevent loading
 ~/.psqlrc

The ~/.psqlrc may alter the output. In particular, I have '\timing on'
in there to add timings. This is useful when using psql, but not when
relying on it in scripts.

For example:

    psql -Aqt -c "select n.nspname \
        from pg_catalog.pg_namespace n \
        where n.nspname "'!~'" '^pg_' \
          and n.nspname <> 'information_schema' \
        order by 1;" postgres 2>/dev/null

Gives the output:

    public
    Time: 1.882 ms

Whereas with -X it gives the standard output:

    public
---
 src/_pgsql_utils | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/_pgsql_utils b/src/_pgsql_utils
index dff7743..e119a2d 100644
--- a/src/_pgsql_utils
+++ b/src/_pgsql_utils
@@ -89,7 +89,7 @@ _pgsql_users () {
 
     _pgsql_user_sql='select r.rolname from pg_catalog.pg_roles r where r.rolcanlogin = true'
 
-    compadd "$@" - $( psql $_pgsql_params[@] -Aqt -c $_pgsql_user_sql template1 2>/dev/null )
+    compadd "$@" - $( psql $_pgsql_params[@] -XAqt -c $_pgsql_user_sql template1 2>/dev/null )
 
 }
 
@@ -122,7 +122,7 @@ _pgsql_tables () {
 	order by 1"
 
     compadd "$@" - \
-        $( psql $_pgsql_params[@] -Aqt -c $_pgsql_table_sql $db 2>/dev/null )
+        $( psql $_pgsql_params[@] -AXqt -c $_pgsql_table_sql $db 2>/dev/null )
 }
 
 _pgsql_schemas () {
@@ -139,7 +139,7 @@ _pgsql_schemas () {
         order by 1;"
 
     compadd "$@" - \
-        $( psql $_pgsql_params[@] -Aqt -c $_pgsql_schema_sql $db 2>/dev/null )
+        $( psql $_pgsql_params[@] -AXqt -c $_pgsql_schema_sql $db 2>/dev/null )
 }
 
 _pgsql_databases () {
@@ -160,7 +160,7 @@ _pgsql_databases () {
 
     compadd "$@" - \
             ${(f)_pgsql_services} \
-            $( psql $_pgsql_params[@] -Atq -c $_pgsql_db_sql template1 2>/dev/null )
+            $( psql $_pgsql_params[@] -AXtq -c $_pgsql_db_sql template1 2>/dev/null )
 }
 
 _pgsql_encodings () {
@@ -170,7 +170,7 @@ _pgsql_encodings () {
     local _pgsql_db_sql
     _pgsql_db_sql="select pg_encoding_to_char(i) from generate_series(0,100) i;"
 
-    compadd "$@" - $( psql $_pgsql_params[@] -Atq -c $_pgsql_db_sql template1  )
+    compadd "$@" - $( psql $_pgsql_params[@] -AXtq -c $_pgsql_db_sql template1  )
 }
 
 

From 76efcab2f936fe375ad1106cd56c16a70137553d Mon Sep 17 00:00:00 2001
From: Martin Tournoij <martin@arp242.net>
Date: Wed, 3 Jun 2020 11:24:41 +0800
Subject: [PATCH 2/2] pgsql: Check for pg_config existence

pg_config isn't installed by default on many systems, and is usually
part of postgresql-libs-devel or some such, leading to needless
"pg_config not found" errors on completion.
---
 src/_pgsql_utils | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/src/_pgsql_utils b/src/_pgsql_utils
index dff7743..cbe2b8e 100644
--- a/src/_pgsql_utils
+++ b/src/_pgsql_utils
@@ -147,10 +147,9 @@ _pgsql_databases () {
     _pgsql_get_identity
 
     local _pgsql_services _pgsql_service_files
-    _pgsql_service_files=(
-      ~/.pg_service.conf
-      $(pg_config --sysconfdir)/pg_service.conf
-    )
+    _pgsql_service_files=(~/.pg_service.conf)
+    (( $+commands[pg_config] )) && _pgsql_service_files+=$(pg_config --sysconfdir)/pg_service.conf
+
     _pgsql_services=$( grep -h '^\[.*\]' $_pgsql_service_files 2>/dev/null \
                          | sed -e 's/^\[/service=/' -e 's/\].*$//' )